feat: make Client send and sync

Cargo.toml

@@ -19,10 +19,10 @@ repository = "https://github.com/0xPolygonMiden/miden-client"
 
 [workspace.dependencies]
 async-trait = "0.1"
-miden-lib = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "next", default-features = false }
-miden-objects = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "next", default-features = false }
-miden-tx = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "next", default-features = false, features = ["async"] }
-miden-tx-prover = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "next", features = ["async"] }
+miden-lib = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "tomyrd-send-sync-traits", default-features = false }
+miden-objects = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "tomyrd-send-sync-traits", default-features = false }
+miden-tx = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "tomyrd-send-sync-traits", default-features = false, features = ["async"] }
+miden-tx-prover = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "tomyrd-send-sync-traits", features = ["async"] }
 rand = { version = "0.8" }
 serde = { version = "1.0", features = ["derive"] }
 thiserror = { version = "2.0", default-features = false }

crates/rust-client/src/lib.rs

@@ -115,7 +115,7 @@ pub struct Client<R: FeltRng> {
     rng: R,
     /// An instance of [NodeRpcClient] which provides a way for the client to connect to the
     /// Miden node.
-    rpc_api: Box<dyn NodeRpcClient + Send>,
+    rpc_api: Box<dyn NodeRpcClient + Send + Sync>,
     /// An instance of a [LocalTransactionProver] which will be the default prover for the client.
     tx_prover: Arc<LocalTransactionProver>,
     tx_executor: TransactionExecutor,
@@ -147,7 +147,7 @@ impl<R: FeltRng> Client<R> {
     ///
     /// Returns an error if the client couldn't be instantiated.
     pub fn new(
-        rpc_api: Box<dyn NodeRpcClient + Send>,
+        rpc_api: Box<dyn NodeRpcClient + Send + Sync>,
         rng: R,
         store: Arc<dyn Store>,
         authenticator: Arc<dyn TransactionAuthenticator>,
@@ -182,7 +182,7 @@ impl<R: FeltRng> Client<R> {
     // --------------------------------------------------------------------------------------------
 
     #[cfg(any(test, feature = "testing"))]
-    pub fn test_rpc_api(&mut self) -> &mut Box<dyn NodeRpcClient + Send> {
+    pub fn test_rpc_api(&mut self) -> &mut Box<dyn NodeRpcClient + Send + Sync> {
         &mut self.rpc_api
     }
 

crates/rust-client/src/store/authenticator.rs

@@ -11,18 +11,18 @@ use rand::Rng;
 use super::Store;
 
 /// Represents an authenticator based on a [Store].
-pub struct StoreAuthenticator<R> {
+pub struct StoreAuthenticator<R: Send + Sync> {
     store: Arc<dyn Store>,
     rng: Arc<RwLock<R>>,
 }
 
-impl<R: Rng> StoreAuthenticator<R> {
+impl<R: Rng + Send + Sync> StoreAuthenticator<R> {
     pub fn new_with_rng(store: Arc<dyn Store>, rng: R) -> Self {
         StoreAuthenticator { store, rng: Arc::new(RwLock::new(rng)) }
     }
 }
 
-impl<R: Rng> TransactionAuthenticator for StoreAuthenticator<R> {
+impl<R: Rng + Send + Sync> TransactionAuthenticator for StoreAuthenticator<R> {
     /// Gets a signature over a message, given a public key.
     ///
     /// The pub key should correspond to one of the keys tracked by the authenticator's store.

crates/rust-client/src/store/web_store/mod.rs

@@ -219,3 +219,6 @@ impl Store for WebStore {
         self.get_unspent_input_note_nullifiers().await
     }
 }
+
+unsafe impl Send for WebStore {}
+unsafe impl Sync for WebStore {}

crates/rust-client/src/transactions/request/mod.rs

@@ -340,21 +340,18 @@ mod tests {
 
     #[test]
     fn transaction_request_serialization() {
-        let sender_id = AccountId::new_dummy(
+        let sender_id = AccountId::dummy(
             [0u8; 15],
             AccountType::RegularAccountImmutableCode,
             AccountStorageMode::Private,
         );
-        let target_id = AccountId::new_dummy(
+        let target_id = AccountId::dummy(
             [1u8; 15],
             AccountType::RegularAccountImmutableCode,
             AccountStorageMode::Public,
         );
-        let faucet_id = AccountId::new_dummy(
-            [2u8; 15],
-            AccountType::FungibleFaucet,
-            AccountStorageMode::Private,
-        );
+        let faucet_id =
+            AccountId::dummy([2u8; 15], AccountType::FungibleFaucet, AccountStorageMode::Private);
         let mut rng = RpoRandomCoin::new(Default::default());
 
         let mut notes = vec![];

crates/web-client/Cargo.toml

@@ -22,7 +22,7 @@ testing = ["miden-client/testing", "miden-tx-prover/testing"]
 miden-client = { version = "0.6", path = "../rust-client", default-features = false, features = ["idxdb", "web-tonic"] }
 miden-lib = { workspace = true }
 miden-objects = { workspace = true }
-miden-tx-prover = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "next", default-features = false, features = ["async"] }
+miden-tx-prover = { git = "https://github.com/0xPolygonMiden/miden-base", branch = "tomyrd-send-sync-traits", default-features = false, features = ["async"] }
 rand = { workspace = true }
 serde = { workspace = true }
 serde-wasm-bindgen = { version = "0.6" }