feat: remove nullifiers from SyncState endpoint #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasArrachea
changed the base branch from
tomasarrachea-stream-sync-state
to
tomasarrachea-filter-nullifiers-by-blocknum
TomasArrachea
force-pushed
the
tomasarrachea-remove-nullifiers-from-sync-state
branch
from
a3ba1ff to
f964017
Compare
Mirko-von-Leipzig
approved these changes
Feb 20, 2025
Base automatically changed from
tomasarrachea-filter-nullifiers-by-blocknum
to
tomasarrachea-stream-sync-state
February 20, 2025 18:53
…ove-nullifiers-from-sync-state
igamigo
approved these changes
Feb 20, 2025
TomasArrachea
changed the base branch from
tomasarrachea-stream-sync-state
to
next
TomasArrachea
changed the base branch from
next
to
tomasarrachea-stream-sync-state
TomasArrachea
merged commit bac6a73
into
tomasarrachea-stream-sync-state
11 checks passed
TomasArrachea
deleted the
tomasarrachea-remove-nullifiers-from-sync-state
branch
TomasArrachea
added a commit
that referenced
this pull request
Feb 20, 2025
* feat: add block_num parameter to check_nullifiers_by_prefix * chore: update CHANGELOG * review: add `block_num` parameter as required * review: update CHANGELOG * review: update doc comment * feat: remove nullifiers from `SyncState` endpoint * chore: update doc comments * chore: update CHANGELOG * chore: update rpc README
TomasArrachea
added a commit
that referenced
this pull request
Feb 20, 2025
* feat: add block_num parameter to check_nullifiers_by_prefix * chore: update CHANGELOG * review: add `block_num` parameter as required * review: update CHANGELOG * review: update doc comment * feat: remove nullifiers from `SyncState` endpoint * chore: update doc comments * chore: update CHANGELOG * chore: update rpc README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the nullifiers from the SyncState request and response. The idea is to update the client to use the
CheckNullifiersByPrefixendpoint.This PR is part of the changes needed for #685.