4318: prototyp.BigInt: fix int64 parsing overflow #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://github.com/0xsequence/issue-tracker/issues/4318
Previously, parsing a string into
BigInt
would silently return 0 on overflow of int64 without any warning. This fix ensures that numbers larger thanint64
are correctly parsed instead of returning 0, because of overflow.Also added handling of negative numbers and tests to cover edge cases related to
int64
parsing.