Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Don't show 'Label added' message if label data is empty #374

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix: Don't show 'Label added' message if label data is empty #374

merged 2 commits into from
Feb 13, 2024

Conversation

burhandodhy
Copy link
Collaborator

Description of the Change

This PR fixes an issue where the  'Label added' message is displayed even when the label fields are empty. 

Closes #356

How to test the Change

  1. Go to the "Labels" page
  2. Submit the form without filling in the data
  3. The plugin will show the "Label added" notice

Changelog Entry

Fixed - Don't show 'Label added' message if label data is empty

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy merged commit 9e68966 into develop Feb 13, 2024
11 checks passed
@burhandodhy burhandodhy deleted the fix/356 branch February 13, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Add New Label" form shows "Label added" notice even when the form fields are empty
2 participants
@burhandodhy @felipeelia