Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N issues based on 2.7.0 #199

Merged
merged 1 commit into from
Apr 11, 2024
Merged

I18N issues based on 2.7.0 #199

merged 1 commit into from
Apr 11, 2024

Conversation

alexclassroom
Copy link
Contributor

Description of the Change

If strings in your plugin are also used in WordPress core (e.g., ‘Settings’), you should still add your own text domain. Otherwise, they’ll become untranslated if the core string changes (which happens). Please refer to this official article.

Closes #

How to test the Change

Add the necessary text domain, and replace previous version files, the UI strings with the missing text domain will be applied the translations from language pack (NOT from Core)

Changelog Entry

Added - The missing Text Domain

Credits

Props @alexclassroom

Checklist:

  • [ x ] I agree to follow this project's Code of Conduct.
  • [ x ] I have updated the documentation accordingly.
  • [ x ] I have added tests to cover my change.
  • [ x ] All new and existing tests pass.

If strings in your plugin are also used in WordPress core (e.g., **‘Settings’**), you should still add your own text domain. Otherwise, they’ll become untranslated if the core string changes (which happens). Please refer to [this official article](https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#add-text-domain-to-strings).
@jeffpaul jeffpaul added this to the 2.7.1 milestone Apr 10, 2024
@dkotter dkotter merged commit a9ade82 into 10up:develop Apr 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants