-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(system): Password encryption for login API. #7825
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package middleware | ||
|
||
import ( | ||
"encoding/base64" | ||
"github.com/1Panel-dev/1Panel/core/app/repo" | ||
"github.com/gin-gonic/gin" | ||
) | ||
|
||
func SetPasswordPublicKey() gin.HandlerFunc { | ||
return func(c *gin.Context) { | ||
cookieKey, _ := c.Cookie("panel_public_key") | ||
settingRepo := repo.NewISettingRepo() | ||
key, _ := settingRepo.Get(repo.WithByKey("PASSWORD_PUBLIC_KEY")) | ||
base64Key := base64.StdEncoding.EncodeToString([]byte(key.Value)) | ||
if base64Key == cookieKey { | ||
c.Next() | ||
return | ||
} | ||
c.SetCookie("panel_public_key", base64Key, 7*24*60*60, "/", "", false, false) | ||
c.Next() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There does not seem to be anything irregular, issue, or optimisation needed in this code snippet. The function names suggest it might have some related methods though which would need verification:
Additionally there is a missing file
aes.go
that needs to include these functions.It's also recommended to consider if importing packages like crypto, x509 should just come from global var here rather than directly requiring them each time they are used unless you're using an external package manager like go mod globally or a custom way of resolving import order for the project. I recommend looking into more concise coding practices for your specific use case.
The rest looks fine but could potentially benefit from cleaner naming conventions, better doc comments and possibly more thorough type annotations when applicable, such as around variables, parameter types, return values etc.