-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate mediasoup WebRTC server from JavaScript to TypeScript #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt to TypeScript using NestJS
gabrielmatau79
changed the title
refactor: Initial commit migrate mediasoup WebRTC server from JavaScript to TypeScript
refactor: migrate mediasoup WebRTC server from JavaScript to TypeScript
Dec 5, 2024
…sion 22 into Dockerfile
lotharking
reviewed
Dec 20, 2024
…move the envFilePath.
genaris
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Time to test it in real deployments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is a complete refactor of a WebRTC server built on Mediasoup, migrating from a previous JavaScript implementation to a robust and structured TypeScript application using the NestJS framework. From the ground up, the architecture was adapted to TypeScript standards, ensuring type safety, improved maintainability, and overall better code quality.
Modularized the project into well-defined components, such as the Rooms module, which handles the creation and management of rooms, and the WebSocket module, which integrates Protoo server for real-time communication. DTOs (Data Transfer Objects) were implemented to validate and type incoming data in controllers. Error handling was enhanced throughout the application, and all controllers were refactored to align with modern TypeScript patterns.
Swagger was integrated to automatically generate comprehensive API documentation, improving the developer experience and making the API easier to understand. We added Docker support for containerization, enabling seamless deployment.