Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodownload CentOS, Autofind GuestAdditions on Mac, Test IP and Detect Local IP on Mac #15

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

smorin
Copy link

@smorin smorin commented Jan 26, 2014

I made a number of improvements but left it backwards compatible with the way the script functioned before.

@smorin
Copy link
Author

smorin commented Jan 26, 2014

Overall what do you think of the improvements? Do you run this on a mac or other environment?

@casr
Copy link
Member

casr commented Jan 26, 2014

Yeah, I'm on a Mac most of the time but I would like to try and keep as cross-platform as possible. Overall, automating the process along is definitely a win. I have kinda have got used to a workflow so it's nice to see some perspective like this and see where the pain points are :) . I'll splice and dice the bits I like and pop them in ASAP.

Something I've been thinking I should do is have some sort of "contributor agreement". Would you be happy if your work here was put in the public domain?

@smorin
Copy link
Author

smorin commented Jan 26, 2014

As for crossplatform, I did checks so that should work fine for most people.

I am using this for my production so would like to keep in sync. I rather not have a fork. I would be happy to be a contributor or just submit pull requests like this.

I am also curious let me know which parts you like and don't like.

Would be happy to change differently if you want, because I want my copy as a downstream to maintain this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants