Feat/multiassetpath #580
Open
Feat/multiassetpath #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only prints arguments and help so far.
util imports numpy, which conflicts with util and platform. Renaming to utils and platforms.
dokempf
requested changes
Mar 4, 2025
|
Thanks for the review, I addressed your comments and fixed the absolute path logic. |
|
@KRiedmiller I just realized, that we need this not only for |
dokempf
reviewed
Mar 7, 2025
python/helios/scene.py
Outdated
| ) | ||
| ) | ||
|
|
||
| return [cls._from_cpp(part) for part in _cpp_parts] |
There was a problem hiding this comment.
Couldn't we just implement this via [ScenePart.from_obj(f) for f in obj_files]. THat would not duplicate the underlying logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse asset paths containing wildcards. This is useful for loading multiple
.objfiles at once into multiple SceneParts.Implements a new MultiAssetPath type. Only functions which want to use this feature need to switch from the unchanged AssetPath to the new MultiAssetPath.
This PR is based on the PR #572 branch
Fixes #557