Move SavedStateHandle into constructor

3yebMB · Oct 18, 2024 · d89e04f · d89e04f
1 parent ab34463
commit d89e04f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/app/src/main/java/dev/m13d/somenet/app/ApplicationModule.kt b/app/src/main/java/dev/m13d/somenet/app/ApplicationModule.kt
@@ -51,6 +51,7 @@ val applicationModule = module {
     viewModel {
         CreatePostViewModel(
             postRepository = get(),
+            savedStateHandle = get(),
             dispatchers = get(),
         )
     }

diff --git a/app/src/main/java/dev/m13d/somenet/postcomposer/CreatePostViewModel.kt b/app/src/main/java/dev/m13d/somenet/postcomposer/CreatePostViewModel.kt
@@ -17,14 +17,14 @@ import kotlinx.coroutines.withContext
 
 class CreatePostViewModel(
     private val postRepository: PostRepository,
+    private val savedStateHandle: SavedStateHandle,
     private val dispatchers: CoroutineDispatchers,
 ) : ViewModel() {
 
     private companion object {
         private const val SCREEN_STATE_KEY = "createPostScreenState"
     }
 
-    private val savedStateHandle = SavedStateHandle()
     val screenState: LiveData<CreateNewPostScreenState> = savedStateHandle.getLiveData(SCREEN_STATE_KEY)
 
     fun createPost(postText: String) {

diff --git a/app/src/test/java/dev/m13d/somenet/postcomposer/CreatePostTest.kt b/app/src/test/java/dev/m13d/somenet/postcomposer/CreatePostTest.kt
@@ -1,5 +1,6 @@
 package dev.m13d.somenet.postcomposer
 
+import androidx.lifecycle.SavedStateHandle
 import dev.m13d.somenet.InstantTaskExecutorExtension
 import dev.m13d.somenet.app.TestDispatchers
 import dev.m13d.somenet.domain.post.InMemoryPostsCatalog
@@ -33,6 +34,7 @@ class CreatePostTest {
                     clock = clock,
                 )
             ),
+            SavedStateHandle(),
             TestDispatchers(),
         )
 
@@ -56,6 +58,7 @@ class CreatePostTest {
                     clock = clock,
                 )
             ),
+            SavedStateHandle(),
             TestDispatchers(),
         )
 

diff --git a/app/src/test/java/dev/m13d/somenet/postcomposer/FailedPostCreationTest.kt b/app/src/test/java/dev/m13d/somenet/postcomposer/FailedPostCreationTest.kt
@@ -1,5 +1,6 @@
 package dev.m13d.somenet.postcomposer
 
+import androidx.lifecycle.SavedStateHandle
 import dev.m13d.somenet.InstantTaskExecutorExtension
 import dev.m13d.somenet.app.TestDispatchers
 import dev.m13d.somenet.domain.post.OfflinePostCatalog
@@ -25,6 +26,7 @@ class FailedPostCreationTest {
                 InMemoryUserDataStore("userId"),
                 UnavailablePostCatalog()
             ),
+            SavedStateHandle(),
             TestDispatchers(),
         )
 
@@ -40,6 +42,7 @@ class FailedPostCreationTest {
                 InMemoryUserDataStore("userId"),
                 OfflinePostCatalog()
             ),
+            SavedStateHandle(),
             TestDispatchers(),
         )
 

diff --git a/app/src/test/java/dev/m13d/somenet/postcomposer/RenderingCreatePostStateTest.kt b/app/src/test/java/dev/m13d/somenet/postcomposer/RenderingCreatePostStateTest.kt
@@ -1,5 +1,6 @@
 package dev.m13d.somenet.postcomposer
 
+import androidx.lifecycle.SavedStateHandle
 import dev.m13d.somenet.InstantTaskExecutorExtension
 import dev.m13d.somenet.app.TestDispatchers
 import dev.m13d.somenet.domain.post.InMemoryPostsCatalog
@@ -31,8 +32,9 @@ class RenderingCreatePostStateTest {
     private val postCatalog = InMemoryPostsCatalog(idGenerator = idGenerator, clock = clock)
     private val userData = InMemoryUserDataStore(loggedInUserId)
     private val postRepository = PostRepository(userData, postCatalog)
+    private val savedStateHandle = SavedStateHandle()
     private val dispatchers = TestDispatchers()
-    private val viewModel = CreatePostViewModel(postRepository, dispatchers)
+    private val viewModel = CreatePostViewModel(postRepository, savedStateHandle, dispatchers)
 
     @Test
     fun uiStatesAreDeliveredInParticularOrder() {