better service type validation

4lando · Feb 7, 2025 · 3ec258a · 3ec258a
1 parent 269e9b8
commit 3ec258a
Showing 1 changed file with 18 additions and 22 deletions.
diff --git a/landofile-spec.json b/landofile-spec.json
@@ -244,14 +244,25 @@
         "properties": {
           "type": {
             "type": "string",
-            "description": "The type of service.",
+            "description": "The Lando service type in the format 'string:version'.",
+            "oneOf": [
+              {
+                "const": "lando"
+              },
+              {
+                "pattern": "^[a-zA-Z0-9_-]+:[0-9]+(\\.[0-9]+)*$",
+              }
+            ],
+            "not": {
+              "pattern": "^[a-zA-Z0-9_-]+$",
+              "description": "Specifying a service type without a version is deprecated. Please include the version."
+            },
             "examples": [
-              "node",
-              "php:7.4",
-              "nginx",
-              "apache",
-              "mysql:5.7",
-              "compose",
+              "node:22",
+              "php:8.4",
+              "nginx:1.27",
+              "apache:2.4",
+              "mysql:8.0",
               "lando"
             ],
             "pattern": "^[a-zA-Z0-9._-]+(:[a-zA-Z0-9._-]+)?$"
@@ -364,21 +375,6 @@
               3000
             ]
           },
-          "portforward": {
-            "description": "Forwards a port to the host OS. Use `true` to allow Docker to manage ports (recommended). You may also specify a port number, but there is risk of conflicting with other services or applications.",
-            "oneOf": [
-              {
-                "type": "boolean"
-              },
-              {
-                "type": "number"
-              }
-            ],
-            "examples": [
-              true,
-              3000
-            ]
-          },
           "scanner": {
             "oneOf": [
               {