Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the access-esm1.5 version and branch of GCOM4 #114

Merged
merged 2 commits into from
May 28, 2024
Merged

Use the access-esm1.5 version and branch of GCOM4 #114

merged 2 commits into from
May 28, 2024

Conversation

penguian
Copy link
Contributor

Closes #112. The um7 executable builds. The output of the pre-industrial configuration does not reproduce bitwise, but this can be addressed by separate issues, such as #113 .

@penguian penguian requested a review from harshula May 24, 2024 07:16
@penguian penguian linked an issue May 24, 2024 that may be closed by this pull request
Use access-esm1.5 branch of GCOM4 for gcom4 #112
Closed
harshula
harshula reviewed May 25, 2024
View reviewed changes
Copy link
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep the import llnl.util.filesystem as fs?

@penguian
Copy link
Contributor Author

Is there a reason to keep the import llnl.util.filesystem as fs?

No. I have now removed it.

@penguian penguian merged commit 30e8ec8 into main May 28, 2024
1 check passed
@penguian penguian deleted the 112-use-access-esm15-branch-of-gcom4 branch May 28, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshula harshula harshula approved these changes

Assignees

@penguian penguian

Labels
None yet
Projects
ACCESS-ESM1.5 Spack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use access-esm1.5 branch of GCOM4 for gcom4
2 participants
@penguian @harshula