Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conditional values for the type variant #116

Merged
merged 1 commit into from
May 28, 2024
Merged

Use conditional values for the type variant #116

merged 1 commit into from
May 28, 2024

Conversation

penguian
Copy link
Contributor

Closes #112
I tested with three different variants:

$ spack find -v mom5
-- linux-rocky8-x86_64 / intel@19.0.5.281 -----------------------
mom5@access-esm1.5~deterministic~optimisation_report+restart_repro build_system=makefile type=ACCESS-CM  mom5@master~deterministic~optimisation_report+restart_repro build_system=makefile type=ACCESS-OM
mom5@master~deterministic~optimisation_report+restart_repro build_system=makefile type=ACCESS-CM
==> 3 installed packages

Everything works for me as I expect. Please test.

@penguian penguian added the bug Something isn't working label May 28, 2024
@penguian penguian requested a review from harshula May 28, 2024 06:08
@penguian penguian self-assigned this May 28, 2024
@penguian penguian linked an issue May 28, 2024 that may be closed by this pull request
mom5 now defaults to "ACCESS-CM" type #115
Closed
@penguian
Copy link
Contributor Author

I am currently running the pre-industrial configuration and it hasn't crashed. If it produces incorrect results, I will create a separate issue.

@penguian penguian merged commit ca9ea12 into main May 28, 2024
1 check passed
@penguian penguian deleted the 115-mom5-now-defaults-to-access-cm-type branch May 28, 2024 07:05
@penguian
Copy link
Contributor Author

The run worked.

@aidanheerdegen aidanheerdegen mentioned this pull request May 30, 2024
Closed
@penguian penguian mentioned this pull request Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshula harshula harshula approved these changes

Assignees

@penguian penguian

Labels
bug Something isn't working
Projects
ACCESS-ESM1.5 Spack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mom5 now defaults to "ACCESS-CM" type Use access-esm1.5 branch of GCOM4 for gcom4
2 participants
@penguian @harshula