-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACCESS-OM2-BGC
Package
#81
Conversation
Hi @CodeGat , Can you please rebase your changes on top of the latest main? |
32aa696
to
1bf38d1
Compare
9df3c86
to
ae467ac
Compare
I tested, and it picked up all the existing builds
which is the correct behaviour, as I had already built the BGC version
It's not a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment change
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
It isn't possible to inherit from the Some attempts were made to circumvent this issue by directly importing the package but they didn't work so that approach was abandoned. |
In this PR:
Closes #80
Closes #73