Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACCESS-OM2-BGC Package #81

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Add ACCESS-OM2-BGC Package #81

merged 3 commits into from
Mar 21, 2024

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Mar 21, 2024

In this PR:


Closes #80
Closes #73

@harshula
Copy link
Collaborator

Hi @CodeGat , Can you please rebase your changes on top of the latest main?

@CodeGat CodeGat force-pushed the 80-access-om2-bgc-package branch from 32aa696 to 1bf38d1 Compare March 21, 2024 05:49
@CodeGat CodeGat force-pushed the 80-access-om2-bgc-package branch from 9df3c86 to ae467ac Compare March 21, 2024 06:36
@CodeGat CodeGat marked this pull request as ready for review March 21, 2024 06:36
@aidanheerdegen
Copy link
Member

I tested, and it picked up all the existing builds

$ spack install access-om2-bgc ^netcdf-c@4.7.4 ^netcdf-fortran@4.5.2  ^openmpi@4.0.2 %intel@19.0.5.281
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/datetime-fortran-1.7.0-aretozixwsdz42owabgzeiuxooyxrspg
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/json-fortran-8.3.0-nyxvikkez6fu64xtbeqqz2a4wngikfgi
==> openmpi@4.0.2 : has external module in ['openmpi/4.0.2']
[+] /apps/openmpi/4.0.2 (external openmpi-4.0.2-4jwtg3nt7p3zsod4rvn3i3jyyop3arpe)
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/pkgconf-1.9.5-uyq7tvpnuuo3gosnplkvuxktaeeipuqk
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/zlib-1.2.13-arj4bfz33zf63gvfionhorrrveci6kb4
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/hdf5-1.14.1-2-a6mpuk7tw5e4pyukxwalooc7jfldalcf
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/netcdf-c-4.7.4-i3inxzaihefr3rqljoovhyevwai6bsff
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/netcdf-fortran-4.5.2-mnx4gghyb5gngsl3fgosud6k72yu2u6a
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/oasis3-mct-master-kv5jbt5qltp2kymqka5joksqbatdzspp
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/parallelio-2.5.2-nwolfzy2xxb4wub65gmvlm3edhuolmlh
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/libaccessom2-master-ajlvl3kyjim4eccn3onqvfp2dvjgyupv
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/mom5-master-aollz5h3gjqjhb3pkgfkkqqifm75hals
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/cice5-master-7ta7toa4fohxrh6ufgantpuobxco4a7c
==> Installing access-om2-bgc-latest-tpq5uvohpx2qofhtgf5sm4ecz4qnkzdn
==> No binary for access-om2-bgc-latest-tpq5uvohpx2qofhtgf5sm4ecz4qnkzdn found: installing from source
==> No patches needed for access-om2-bgc
==> access-om2-bgc: Executing phase: 'install'
==> access-om2-bgc: Successfully installed access-om2-bgc-latest-tpq5uvohpx2qofhtgf5sm4ecz4qnkzdn
  Stage: 0.01s.  Install: 0.00s.  Post-install: 1.66s.  Total: 4.42s
[+] /g/data/tm70/aph502/spack-build/release/linux-rocky8-x86_64/intel-19.0.5.281/access-om2-bgc-latest-tpq5uvohpx2qofhtgf5sm4ecz4qnkzdn

which is the correct behaviour, as I had already built the BGC version

aollz5h3gjqjhb3pkgfkkqqifm75hals mom5@master~deterministic~optimisation_report build_system=makefile type=ACCESS-OM-BGC

It's not a +restart_repro but that default hasn't been set yet IIRC

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment change

Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
@CodeGat CodeGat merged commit 244d483 into main Mar 21, 2024
1 check passed
@CodeGat CodeGat deleted the 80-access-om2-bgc-package branch March 21, 2024 06:53
@harshula harshula self-requested a review March 21, 2024 07:12
Copy link
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@aidanheerdegen
Copy link
Member

It isn't possible to inherit from the access-om2 class in a simple way because the hyphen in the package name makes simple importing impossible.

Some attempts were made to circumvent this issue by directly importing the package but they didn't work so that approach was abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate SPD for ACCESS-OM2 biogeochemistry (BGC) build Remove line length restriction on ruff CI checks
3 participants