-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/keyboard mapping #88
Draft
Vermino
wants to merge
5
commits into
ACEmulator:master
Choose a base branch
from
Vermino:feature/keyboard-mapping
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ALT + Plus or Minus to go up or down a Z level - Shift hotkey has been added to decrease Z Level
Implements a comprehensive keyboard configuration system allowing users to customize and manage keybindings throughout the application. This new system includes a dedicated configuration UI accessible through Tools -> Keyboard Configuration. Core Features: - Configurable bindings for camera and Z-level controls - Multiple predefined keyboard layouts (WASD, ESDF, Arrow keys) - Import/Export functionality for sharing keybinding configurations - Real-time conflict detection and validation - Search functionality to easily find specific bindings - Category-based organization of keybindings Technical Implementation: - New KeyBinding system with modifier key support - Action-based input handling system - JSON-based configuration persistence - Migration system for future config updates - Extensible architecture for adding new bindable actions UI Components: - KeyboardConfig window for managing all bindings - KeyBindingDialog for capturing new key combinations - SearchBox for filtering available bindings - Profile selector for quick layout switching Modified Components: - Camera.cs: Removed hardcoded keys, now using action system - Config.cs: Added KeyBindings support - MainMenu.xaml: Added Keyboard Configuration option - ConfigManager: Added keybinding save/load functionality New Files: - Entity/KeyBinding.cs - Config/KeyBindingConfig.cs - Input/InputManager.cs - Input/KeyRecorder.cs - Model/UserAction.cs - Model/ActionRegistry.cs - Config/ConfigMigration.cs - View/KeyboardConfig.xaml/cs - View/KeyBindingDialog.xaml/cs Testing: - Verified key recording functionality - Tested conflict detection - Validated import/export features - Confirmed proper persistence of settings - Checked migration system functionality Note: This change removes hardcoded key bindings from the Camera class and introduces a more flexible, maintainable approach to input handling throughout the application.
Implements a comprehensive keyboard configuration system allowing users to customize and manage keybindings throughout the application. This new system includes a dedicated configuration UI accessible through Tools -> Keyboard Configuration. Core Features: - Configurable bindings for camera and Z-level controls - Multiple predefined keyboard layouts (WASD, ESDF, Arrow keys) - Import/Export functionality for sharing keybinding configurations - Real-time conflict detection and validation - Search functionality to easily find specific bindings - Category-based organization of keybindings Technical Implementation: - New KeyBinding system with modifier key support - Action-based input handling system - JSON-based configuration persistence - Migration system for future config updates - Extensible architecture for adding new bindable actions UI Components: - KeyboardConfig window for managing all bindings - KeyBindingDialog for capturing new key combinations - SearchBox for filtering available bindings - Profile selector for quick layout switching Modified Components: - Camera.cs: Removed hardcoded keys, now using action system - Config.cs: Added KeyBindings support - MainMenu.xaml: Added Keyboard Configuration option - ConfigManager: Added keybinding save/load functionality New Files: - Entity/KeyBinding.cs - Config/KeyBindingConfig.cs - Input/InputManager.cs - Input/KeyRecorder.cs - Model/UserAction.cs - Model/ActionRegistry.cs - Config/ConfigMigration.cs - View/KeyboardConfig.xaml/cs - View/KeyBindingDialog.xaml/cs Testing: - Verified key recording functionality - Tested conflict detection - Validated import/export features - Confirmed proper persistence of settings - Checked migration system functionality Note: This change removes hardcoded key bindings from the Camera class and introduces a more flexible, maintainable approach to input handling throughout the application.
…eature/keyboard-mapping # Conflicts: # ACViewer/Config/ConfigManager.cs # ACViewer/Config/KeyBindingConfig.cs # ACViewer/Input/KeyRecorder.cs # ACViewer/View/KeyboardConfig.xaml.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.