chore:update manageraccess entity #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvanhenang
requested review from
francis-pouatcha,
Elwizzy12,
Arielpetit and
Koufan-De-King
Koufan-De-King
approved these changes
Oct 2, 2024
NkwaTambe
requested changes
Oct 2, 2024
Comment on lines
+1
to
+37
| package de.adorsys.ledgers.baam.db.domain; | ||
|
|
||
| import jakarta.persistence.*; | ||
| import lombok.Data; | ||
| import lombok.NoArgsConstructor; | ||
| import lombok.AllArgsConstructor; | ||
|
|
||
|
|
||
| import java.util.HashSet; | ||
| import java.util.Set; | ||
| import java.util.UUID; | ||
|
|
||
| @Entity | ||
| @Data | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public class ManagerAccess { | ||
|
|
||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.UUID) | ||
| private UUID id; | ||
|
|
||
| private String name; | ||
|
|
||
|
|
||
| private double weight; // Level of access (0 to 1) | ||
|
|
||
| @Enumerated(EnumType.STRING) | ||
| private AccessStatus status; | ||
|
|
||
| @ElementCollection | ||
| private Set<TypeOfManagedAccess> managedAccessTypes = new HashSet<>(); | ||
|
|
||
| @ElementCollection | ||
| private Set<AccessScope> scopeOfAccess = new HashSet<>(); | ||
|
|
||
| } |
There was a problem hiding this comment.
Good job @yvanhenang
but to make these clear, i think you should extend your class to the BankAccountAcess entity.
let's use inheritance as the BankAccountAcess entity serves as an entery point to all accesses
| @BeforeEach | ||
| public void setup() { | ||
| // Initialize a ManagerAccess object for testing | ||
| managerAccess = new ManagerAccess(); |
There was a problem hiding this comment.
These is correct but not a good practice for our case..
it should be ManagerAcess managerAccess = new ManagerAccess(); and not managerAccess = new ManagerAccess();
|
Hello @yvanhenang please read again the ticket description for more insight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the pom.xml to manage dependencies for access management functionality. Enhanced AccessScope and ManagerAccess domain models to refine permissions and scope definitions. Added integration tests in ManagerAccessRepositoryIT to ensure proper functionality of manager-level access features