Remove hard-code numerical tests for randomly-generated data #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klamike
requested changes
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
klamike
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last thing to finally un-break CI 🤞
This PR removes hard-coded randomly-generated values, which have been triggering countless CI failures, and are a pain to maintain in the long run.
It also replacesMersenneTwisterrandom number generators withStableRNGfor unit tests; this is to reduce the risk of a silent change toMersenneTwistersomehow affecting unit tests.Note that we should still use
MersenneTwisterwhen generating datasets.