Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Geant4VolumeManager #1390

Merged
merged 12 commits into from
Jan 25, 2025

Conversation

MarkusFrankATcernch
Copy link
Contributor

BEGINRELEASENOTES

  • Optimize the Geant4VolumeManager. Instead of mapping the Geant4 pathes as vectors of pointers,
    hash64 the pointers of the path and lookup pathes from the touchable history using this key.
  • Relevant changes are in the files DDG4/Geant4GeometryInfo.h and src/Geant4VolumeManager.cpp.
    Everything else is only cosmetics.

ENDRELEASENOTES

Copy link

github-actions bot commented Jan 25, 2025

Test Results

   16 files     16 suites   6h 7m 29s ⏱️
  370 tests   370 ✅ 0 💤 0 ❌
2 887 runs  2 887 ✅ 0 💤 0 ❌

Results for commit 3984eec.

♻️ This comment has been updated with latest results.

@MarkusFrankATcernch MarkusFrankATcernch merged commit 4114265 into AIDASoft:master Jan 25, 2025
16 checks passed
@MarkusFrankATcernch
Copy link
Contributor Author

MarkusFrankATcernch commented Jan 25, 2025

This MR should optimize the memory usage of the Geany4VolumeManager in
up to some degree should overcome the need to use #1288.
The memory consumption of the Geany4VolumeManager as presented here should be largely reduced: instead of performing lookups with vectors of pointers as key only 64bit hash values are used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant