Add support for interface types #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
tmadlener
force-pushed
the
interface-types-variant
branch
2 times, most recently
from
21ac810 to
a72e767
Compare
tmadlener
force-pushed
the
interface-types-variant
branch
from
a72e767 to
443a654
Compare
tmadlener
changed the title
tmadlener
force-pushed
the
interface-types-variant
branch
2 times, most recently
from
3f99856 to
29cac56
Compare
|
Julia code generation cannot really deal with interface types at the moment. I will probably just filter them out at generation time to make the tests pass here. |
|
Waiting on #527 to have a cleaner basis for adding interface types only for c++. |
tmadlener
force-pushed
the
interface-types-variant
branch
2 times, most recently
from
7a86ce4 to
0c81511
Compare
tmadlener
force-pushed
the
interface-types-variant
branch
from
c4aab0d to
1bf3632
Compare
2 tasks
tmadlener
force-pushed
the
interface-types-variant
branch
from
1bf3632 to
4cdb295
Compare
tmadlener
commented
Dec 18, 2023
tmadlener
force-pushed
the
interface-types-variant
branch
2 times, most recently
from
b40fec3 to
0274858
Compare
Avoid collisions downstream
tmadlener
force-pushed
the
interface-types-variant
branch
from
0274858 to
1c11678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
interfaces. These can be used to provide a type that can be initialized from several other datatypes and offers some common functionality. These interface types can be used inOneToOneRelations and inOneToManyRelations.interfacesneed to provide a list of types which they interface. Other types cannot be used with them.ENDRELEASENOTES
Draft resurrection of #215 with the major difference that this no longer uses a
std::variantof theObj*types, but rather relies on a type-erased wrapping of the default handle types. Additionally, this also no longer supports mutable interface types, as I don't think we really have a use case for them.MaybeSharedPtrfor managing user facing objects #514 (builds directly on top of that)