Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Added graphviz dependency (Resolves #637) #660

Merged
merged 4 commits into from
Sep 5, 2024
Merged

[fix] Added graphviz dependency (Resolves #637) #660

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b50358a
Add dependency `graphviz`
SaxenaAnushka102 Sep 3, 2024
e992780
Add to requirements.txt
SaxenaAnushka102 Sep 4, 2024
2c3706e
Revert "Add dependency `graphviz`"
SaxenaAnushka102 Sep 4, 2024
3ea3511
Remove empty line
tmadlener Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ docutils==0.20.1
# myst-parser
# sphinx
# sphinx-rtd-theme
graphviz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually needs to go here and then we use pip-compile to generate the actual requirements.txt from there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmadlener Thanks for explaining, I've updated requirements.in . I'm sorry for adding the dependency to an auto-generated file 😅

idna==3.7
# via requests
imagesize==1.4.1
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
pyyaml
jinja2
tabulate
graphviz
SaxenaAnushka102 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
graphviz
graphviz

Something in your editor settings seems to strip off the last newline in each file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. I'll check for the new lines from next time. Thanks!