-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6 add schemaorg data to head of view page #15
Open
nbodony
wants to merge
11
commits into
main
Choose a base branch
from
6-add-schemaorg-data-to-head-of-view-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creates an initial and very incomplete schema string which can reached at /ld/dataset
make schema a python dict convert dict to json string make variable list of creator blocks move script to view.html pass schema_string to view.html head
robkooper
requested changes
Sep 5, 2024
Removed unnecessary arrays and added one necessary array added keywords with correct spacing after colon commented out unused lines in json_ld_dict replaced 'schema' with 'json_ld' added missing spaces after colons
robkooper
requested changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Json-ld string is placed in head of view.html and can be found at /ld/dataset. It only includes the information that I was aware of and thought to include so it's definitely not complete but I think it works how it's supposed to and is placed everywhere it needs to be.
/ld/piglife:

/ld/slamdataset: (the list of authors is very long)

/view/slamdataset:

/view/piglife
