Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove syntax dependency on semantics #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove syntax dependency on semantics #111

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb15542
Removed syntax dependency on semantics
andrey-norkin Jan 10, 2024
3636d6b
Change setIdx to setOrd
andrey-norkin Jan 11, 2024
63fa5e3
Update 06.bitstream.syntax.md
andrey-norkin Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions 06.bitstream.syntax.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ each of the syntax elements is presented in [Section 6][].
| /* Add reserved bits so that av1_film_grain_payload is byte aligned */
| @@reserved_4bits | f(4)
| @@num_film_grain_sets_minus1 | f(3)
| for ( i = 0; i < num_film_grain_sets_minus1 + 1; i++ ) { |
| av1_film_grain_payload( )
| for ( setOrd = 0; setOrd < num_film_grain_sets_minus1 + 1; setOrd++ ) { |
| av1_film_grain_payload( setOrd )
| }
| selectedParamSet = select_film_grain_param_set( )
| load_grain_params( selectedParamSet )
Expand All @@ -41,7 +41,7 @@ each of the syntax elements is presented in [Section 6][].
### Film grain parameter payload syntax

| ----------------------------------------------------------------- | ---------------- |
| av1_film_grain_payload( ) { | **Type**
| av1_film_grain_payload( setOrd ) { | **Type**
| /* Store the current bit-stream position */
| startPosition = get_position( )
|
Expand All @@ -55,7 +55,7 @@ each of the syntax elements is presented in [Section 6][].
| @@payload_size | f(n)
|
| /* Receive the film grain parameters */
| av1_film_grain_params( )
| av1_film_grain_params( setOrd )
|
| /* Determine the number of bits consumed by the payload */
| currentPosition = get_position( )
Expand All @@ -70,8 +70,10 @@ each of the syntax elements is presented in [Section 6][].
### Film grain parameters syntax

| --------------------------------------------------------- | ---------------- |
| av1_film_grain_params( ) { | **Type**
| av1_film_grain_params( setOrd ) { | **Type**
| @@film_grain_param_set_idx | f(3)
| if (!setOrd)
| filmGrainParamSetIdxForPrediction = film_grain_param_set_idx
| @@apply_grain_flag | f(1)
| if ( !apply_grain_flag ) {
| load_grain_params( film_grain_param_set_idx )
Expand Down Expand Up @@ -112,7 +114,7 @@ each of the syntax elements is presented in [Section 6][].
| video_full_range_flag | f(1)
| }
| }
| @@predict_scaling_flag | f(1)
| @@predict_scaling_flag | f(1)
| if (predict_scaling_flag) {
| @@predict_y_scaling_flag | f(1)
| } else {
Expand All @@ -130,6 +132,8 @@ each of the syntax elements is presented in [Section 6][].
| }
| } else {
| @@num_y_points | f(4)
| if (!setOrd)
| numYPointsInRef = num_y_points
| if (num_y_points) {
| @@point_y_value_increment_bits_minus1 | f(3)
| bitsIncr = point_y_value_increment_bits_minus1 + 1
Expand Down Expand Up @@ -166,6 +170,8 @@ each of the syntax elements is presented in [Section 6][].
| }
| } else {
| @@num_cb_points | f(4)
| if (!setOrd)
| numCbPointsInRef = num_cb_points
| if (num_cb_points) {
| @@point_cb_value_increment_bits_minus1 | f(3)
| bitsIncr = point_cb_value_increment_bits_minus1 + 1
Expand Down Expand Up @@ -194,6 +200,8 @@ each of the syntax elements is presented in [Section 6][].
| }
| } else {
| @@num_cr_points | f(4)
| if (!setOrd)
| numCrPointsInRef = num_cr_points
| if (num_cr_points) {
| @@point_cr_value_increment_bits_minus1 | f(3)
| bitsIncr = point_cr_value_increment_bits_minus1 + 1
Expand Down