Add #102 + Small refactor #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerS1066
reviewed
Aug 2, 2024
src/main/java/net/countercraft/movecraft/combat/features/directors/AADirectors.java
Outdated
Show resolved
Hide resolved
TylerS1066
approved these changes
Aug 3, 2024
TylerS1066
requested changes
Aug 3, 2024
|
I am not sure how, but this PR seems to have broken AA directors. It also only applies when a fireball is directed, which I'm not sure is the intent. |
|
What do you mean with broken AA directors, it works for me. Yeah tested it right now and it looks like it doesn't apply it to undirected fireballs, maybe it is better if i make a runnable that processes each fireball spawned |
TylerS1066
requested changes
Aug 4, 2024
src/main/java/net/countercraft/movecraft/combat/features/directors/AADirectors.java
Outdated
Show resolved
Hide resolved
Probably, in which case it may be best to do it within it's own class or combine it with |
Intybyte
commented
Aug 6, 2024
TylerS1066
approved these changes
Aug 8, 2024
TylerS1066
added a commit
that referenced
this pull request
Aug 11, 2024
This reverts commit 2605f4b.
TylerS1066
added a commit
that referenced
this pull request
Aug 11, 2024
This reverts commit 2605f4b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add #102
Made a config line for AA fireball speed and refactored a small part of the code for better readibility.
I prefered implementing it in
AADirectorsasFireballLifespanwouldn't retain the speed, asa timer task would fix the issue I resued theAADirectorsrunnable.