Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make python expert potion #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make python expert potion #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
067660b
Make python expert potion
Aug 30, 2023
c0426ba
Add docstring for make_python_expert_potion()
Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions brewing/brew_potions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import potion_class
import containers
import cooking
import inspection
from brewing import potion_class
from brewing import containers
from brewing import cooking
from brewing import inspection


def make_example_potion(student_name="ASPP student"):
Expand All @@ -15,13 +15,30 @@ def make_example_potion(student_name="ASPP student"):


def make_python_expert_potion(student_name):
""""
Takes a string indicating the name of a student and returns a "Potion" object.

The function sets the following properties of the Potion object:
- container
- heat_source
- ingredients
- simmer_duration
according to the "python_expert" target_portion specification for
brewing.inspection.inspection_by_Snape()

"""
print("I am a Python Expert")
# todo: write this function!
return
my_potion = potion_class.Potion(student_name=student_name)
# Set up your old kettle and light an eternal flame underneath it.
my_potion.setup(container=containers.pewter_cauldron, heat_source=cooking.fire)
my_potion.add_ingredients(ingredients=['fish_eyes','tea_leaves','unicorn_hair'])
cooking.simmer(my_potion, duration=2)
return my_potion


if __name__ == "__main__":
my_name = 'ASPP student'
my_potion = make_example_potion(student_name=my_name)
my_potion = make_python_expert_potion(student_name=my_name)
# Let Snape inspect the potion
inspection.inspection_by_Snape(potion=my_potion, target_potion='example_potion')
inspection.inspection_by_Snape(potion=my_potion, target_potion='python_expert')