Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to import/export admin settings #196

Merged
merged 3 commits into from
Jul 26, 2016

Conversation

raghavio
Copy link
Collaborator

No description provided.

@@ -283,3 +283,18 @@ def _load_contacts(place, data):
contacts += p.add_contacts(prows)
db.session.commit()
return contacts


@app.route("/admin/settings/export", methods=['GET'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the URL /admin/committee-structures/export and move this code to committees plugin.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we gonna have separate endpoint for each export?
I was thinking to do it just once in admin settings. Like mentioned in #182.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we gonna have separate endpoint for each export?

I was thinking to do it just once in admin settings. Like mentioned in
#182 #182.

Even if we choose to have a single export of everything, it might be good
to have individual exports.

The right way to have single export option work without having the import
the plugins is by maintaining a registry. I'll add a detailed note about
this a little later.

For now, could you please move that code to committees and add individual
exports?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Take a look and let me know.

On Sun, Jul 17, 2016 at 9:44 PM +0530, "Anand Chitipothu" <notifications@github.commailto:notifications@github.com> wrote:

In cleansweep/views/admin.pyhttps://github.com//pull/196#discussion_r71084917:

@@ -283,3 +283,18 @@ def _load_contacts(place, data):
contacts += p.add_contacts(prows)
db.session.commit()
return contacts
+
+
+@app.route("/admin/settings/export", methods=['GET'])

Are we gonna have separate endpoint for each export? I was thinking to do it just once in admin settings. Like mentioned in #182#182 <#182https://github.com/AamAadmiParty/cleansweep/issues/182>.
Even if we choose to have a single export of everything, it might be good to have individual exports. The right way to have single export option work without having the import the plugins is by maintaining a registry. I'll add a detailed note about this a little later. For now, could you please move that code to committees and add individual exports?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/196/files/95932c4a9a342d0575a348295739bbef0d174df0#r71084917, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEpXy-541Kp00RjTe-Tkhc886fTjr5fPks5qWlTNgaJpZM4JOPrY.

@anandology
Copy link
Contributor

What if a permission group used by a committee type is not defined in the instance when importing the committee structures?

@anandology
Copy link
Contributor

That is an open issue. I'm merging it anyway as we can worry about that in a separate issue.

@anandology anandology merged commit c39d1e1 into AamAadmiParty:master Jul 26, 2016
@raghavio
Copy link
Collaborator Author

Not sure what to do in that case. 😕

On Tue, Jul 26, 2016 at 7:10 AM +0530, "Anand Chitipothu" <notifications@github.commailto:notifications@github.com> wrote:

What if a permission group used by a committee type is not defined in the instance when importing the committee structures?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/196#issuecomment-235138330, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEpXy7Mz9vZcS-qOSBkCfDLf0_EgvabRks5qZWWTgaJpZM4JOPrY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants