chore: update review comments

Adyen · Feb 9, 2024 · 63016fd · 63016fd
1 parent 7e1a7f3
commit 63016fd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/Adyen/Analytics/AnalyticsProvider/AnalyticsProvider.swift b/Adyen/Analytics/AnalyticsProvider/AnalyticsProvider.swift
@@ -79,19 +79,19 @@ internal final class AnalyticsProvider: AnalyticsProviderProtocol {
                                           additionalFields: additionalFields,
                                           context: configuration.context)
 
-        fetchCheckoutAttemptId(with: analyticsData)
-    }
-
-    private func fetchCheckoutAttemptId(with initialAnalyticsData: AnalyticsData) {
-        let initialAnalyticsRequest = InitialAnalyticsRequest(data: initialAnalyticsData)
+        let initialAnalyticsRequest = InitialAnalyticsRequest(data: analyticsData)
 
         uniqueAssetAPIClient.perform(initialAnalyticsRequest) { [weak self] result in
-            switch result {
-            case let .success(response):
-                self?.checkoutAttemptId = response.checkoutAttemptId
-            case .failure:
-                self?.checkoutAttemptId = nil
-            }
+            self?.saveCheckoutAttemptId(from: result)
+        }
+    }
+
+    private func saveCheckoutAttemptId(from result: Result<InitialAnalyticsResponse, Error>) {
+        switch result {
+        case let .success(response):
+            checkoutAttemptId = response.checkoutAttemptId
+        case .failure:
+            checkoutAttemptId = nil
         }
     }
 }
diff --git a/Adyen/Analytics/Models/AnalyticsData.swift b/Adyen/Analytics/Models/AnalyticsData.swift
@@ -105,8 +105,6 @@ internal struct AnalyticsData: Encodable {
             self.component = type
         case let .components(type):
             self.component = type.rawValue
-        default:
-            self.component = ""
         }
     }
 }