Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change Conforming PaymentMethods to Codable #1478

Merged
merged 13 commits into from
Jan 25, 2024
Merged

change Conforming PaymentMethods to Codable #1478

merged 13 commits into from
Jan 25, 2024

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Dec 1, 2023 •
edited
Loading

Changed

Custom conformances to PaymentMethod and StoredPaymentMethod are now required to be Encodable

Summary

  • Conforming PaymentMethods to Codable
    • Adding Codable requirement to PaymentMethod + StoredPaymentMethod
  • Renaming PaymentMethodDecoder to PaymentMethodInterpreter
    • Adding translation function from any PaymentMethod to a concrete AnyPaymentMethod
  • Implementing Encodable conformance when needed
  • Moving AnyPaymentMethod to its own file

@goergisn goergisn added the changed a pull request that changed some thing label Dec 1, 2023
@goergisn goergisn requested a review from erenbesel December 1, 2023 16:03
github-actions[bot]
github-actions bot previously approved these changes Dec 1, 2023
View reviewed changes
@goergisn goergisn requested a review from descorp December 1, 2023 16:04
github-actions[bot]
github-actions bot previously approved these changes Dec 1, 2023
View reviewed changes
@goergisn goergisn marked this pull request as ready for review December 4, 2023 09:03
github-actions[bot]
github-actions bot previously approved these changes Dec 4, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Dec 4, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Dec 4, 2023
View reviewed changes
@goergisn goergisn marked this pull request as draft December 4, 2023 16:16
github-actions[bot]
github-actions bot previously approved these changes Dec 5, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Dec 5, 2023
View reviewed changes
@goergisn goergisn requested a review from erenbesel December 6, 2023 10:52
@goergisn goergisn requested a review from atmamont January 18, 2024 10:18
@goergisn goergisn marked this pull request as ready for review January 24, 2024 15:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
91.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@goergisn goergisn merged commit 3a33db9 into develop Jan 25, 2024
14 checks passed
@goergisn goergisn deleted the codable-payment-methods branch January 25, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@descorp descorp descorp approved these changes

@erenbesel erenbesel erenbesel approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@neelSharma12 neelSharma12 neelSharma12 approved these changes

@atmamont atmamont Awaiting requested review from atmamont

Assignees
No one assigned
Labels
changed a pull request that changed some thing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goergisn @descorp @erenbesel @neelSharma12