Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken CI workflows (v4) #1948

Merged
merged 59 commits into from
Jan 21, 2025
Merged

Fix broken CI workflows (v4) #1948

merged 59 commits into from
Jan 21, 2025

Conversation

nauaros
Copy link
Contributor

@nauaros nauaros commented Jan 15, 2025 •
edited
Loading

Summary

  • Updated workflow runners to macos-14-xlarge.
  • Upgraded device destinations in all affected jobs.
  • Modified Coder to output using sortedKeys.
  • Defined encodeWithSortedKeys in JSONEncoder.
  • Fixed unit tests broken by updates in Swift 6 and Xcode 16.

Issue

GitHub Actions deprecated the macos-12 runners, causing workflows relying on them to fail. To restore functionality, we've updated to newer runners. This update also necessitated upgrading the selected Xcode version and device destinations in the jobs. Additionally, some unit tests were broken due to changes in the latest Xcode version, which have now been fixed.

Ticket

COIOS-853

@nauaros nauaros self-assigned this Jan 15, 2025
@nauaros nauaros added the chore a pull request that has chore changes that shouldn't be in the release notes label Jan 15, 2025
@goergisn goergisn requested review from atmamont and goergisn January 20, 2025 15:47
@nauaros nauaros changed the title Update CI workflows Fix broken CI workflows (v4) Jan 21, 2025
atmamont
atmamont previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@atmamont atmamont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Naufal!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nauaros nauaros merged commit c1e8eda into v4 Jan 21, 2025
7 checks passed
@nauaros nauaros deleted the update-ci-machine-version branch January 21, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goergisn goergisn goergisn approved these changes

@atmamont atmamont atmamont approved these changes

Assignees

@nauaros nauaros

Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nauaros @goergisn @atmamont