Add accessibility identifier to Apple Pay pre-page root view #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmamont
added
the
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nauaros
approved these changes
Jan 27, 2025
erenbesel
approved these changes
Jan 27, 2025
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
neelSharma12
approved these changes
Jan 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our current system to build accessibility identifier in runtime doesn't really work nicely when root view
doesn't have an identifier.
PreApplePayViewis an "orphan" view that is presented using abstractADYViewControllerand doesn't have and shouldn't have any accessibility logic. It's up to a child view to decide and while we don't have many such cases, it seems to be one of them.Before
<Adyen.PreApplePayView: 0x103374f00; frame = (0 0; 0 0); layer = <CALayer: 0x60000036b900>>.applePayButtonAfter
adyen.preApplePay.applePayButtonTicket
COIOS-000