Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release note workflow escaping #1999

Merged
merged 12 commits into from
Jan 31, 2025
Merged

Release note workflow escaping #1999

merged 12 commits into from
Jan 31, 2025

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Jan 31, 2025 •
edited
Loading

Summary

  • Using escaping for release notes instead of a token
  • Improving output

COIOS-000

github-actions[bot]
github-actions bot requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@goergisn goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ No changes detected

Comparing release-note-workflow-escaping to develop

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

atmamont
atmamont approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@atmamont atmamont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make it a rule to leave comments for complex actions syntax.
Great stuff!

@goergisn goergisn merged commit 9ee4002 into develop Jan 31, 2025
16 of 17 checks passed
@goergisn goergisn deleted the release-note-workflow-escaping branch January 31, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmamont atmamont atmamont approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@neelSharma12 neelSharma12 neelSharma12 approved these changes

Assignees
No one assigned
Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goergisn @atmamont @neelSharma12