-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch name validation script #2017
Conversation
Should we enable base PR checks for new branches subset? |
d50c3c9
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
Looks great! Some potential improvement for the future would be validating the version number if it's a |
|
Problem
We realized we currently only have branch rules for develop, meaning any PR targeted to any other branch than develop can be freely merged without our branch rules (e.g., 3 approvals, resolved conversations, green CI etc).
Solution
Github allows creating rules for specific branches but that would mean we would need a new rule for every new branch which is not sustainable. Fortunately Github also allows rules for branch folders such as
feature/*
so we can create branch rules under such folders.This would require all future branches to be created with these prefixes. This PR achieves it with a script and add it in our pre-commit hook.
Currently naming format is
{labelName}/{branchName}
labelName
=feature, fix, chore, improvement, release
branchName
= Any name ( can be made to always include COIOS string)Ticket
COIOS-870