Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout XML checkout_index_index should not set page layout #81

Closed
kweij opened this issue Dec 6, 2024 · 1 comment · Fixed by #82
Closed

Layout XML checkout_index_index should not set page layout #81

kweij opened this issue Dec 6, 2024 · 1 comment · Fixed by #82
Assignees

Comments

@kweij
Copy link
Contributor

kweij commented Dec 6, 2024

Describe the bug
The layout XML explicitly sets the page layout to "checkout". This is unnecessary and should be left to the integrator or custom theme. Because of this attribute, an override on Adyen_Hyva is required while the checkout page layout should not be part of scope of the payment method provider.

To Reproduce
Steps to reproduce the behavior:

  • Customize the checkout page layout in the Hyva_Checkout module namespace and change it "1-column"
  • View the checkout
  • See that it uses the "checkout" page layout

Expected behavior

  • View the checkout
  • See that it uses the "1-column" page layout

Magento version
2.4.6.p8

Plugin version
1.2.1

Screenshots
n/a

Desktop (please complete the following information):

  • OS: MacOs
  • Browser: Chrome
  • Version: Any

Smartphone (please complete the following information):
n/a

Additional context
Add any other context about the problem here.

@khushboo-singhvi
Copy link
Contributor

Hello @kweij,

Thank you for reporting this issue and providing a fix alongside. The PR is under review.

Regards!
Khushboo

@khushboo-singhvi khushboo-singhvi linked a pull request Dec 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants