Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remove page layout #82

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Update remove page layout #82

merged 4 commits into from
Feb 18, 2025

Conversation

kweij
Copy link
Contributor

@kweij kweij commented Dec 6, 2024

Remove unnecessary setting/overriding of the page layout in the checkout

Summary

The layout XML explicitly sets the page layout to "checkout". This is unnecessary and should be left to the integrator or custom theme. Because of this attribute, an override on Adyen_Hyva is required while the checkout page layout should not be part of scope of the payment method provider.

Tested scenarios

Customised checkout page layout in the Hyva_Checkout module namespace where it was changed to "1-column". Now it remains "1-column" and isn't overridden by this module.

Fixed issue: #81

Remove unnecessary setting/overriding of the page layout in the checkout
@kweij kweij requested a review from a team as a code owner December 6, 2024 09:30
@khushboo-singhvi khushboo-singhvi linked an issue Dec 16, 2024 that may be closed by this pull request
@candemiralp
Copy link
Member

Hello @kweij,

Thank you for your contribution. This PR will be merged and released.

Best Regards,
Can

@candemiralp candemiralp merged commit 597642f into Adyen:develop Feb 18, 2025
5 checks passed
@candemiralp candemiralp mentioned this pull request Feb 19, 2025
@candemiralp candemiralp added the Fix Indicates a bug fix label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout XML checkout_index_index should not set page layout
3 participants