Release 1.2.0 #61
Merged
Release 1.2.0 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
khushboo-singhvi
commented
Oct 3, 2024
•
khushboo-singhvi
commented
- [ECP-9298] Add support for facilypay-3x #50
- Adding main.yml and sonarcloud properties to hyva #56
- feat: disable place order button for adyen_cc #58
* add support for facilypay-3x * cleanup logs * add nested data obj in component config obj * revert redundant line removal * polish after code review * Update view/frontend/templates/payment/model/adyen-payment-method.phtml Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> --------- Co-authored-by: Can Demiralp <ecandemiralp@gmail.com>
Disable button as default. Button gets enabled after all cc form fields are filled out correctly. Closes #55 Co-authored-by: Khushboo <khushboo.singhvi@adyen.com>
* Adding main.yml and sonarcloud properties to hyva * Debugging * Removing phpcs * Removing php unit tests * Removing php unit tests * Update .github/workflows/main.yml Removing scan on pull_request_target Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> --------- Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> Co-authored-by: Peter Ojo <peterojo@users.noreply.github.com>
|
|
Please retry analysis of this Pull-Request directly on SonarCloud |
candemiralp
approved these changes
Oct 3, 2024
peterojo
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.