Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-9572] Implement agreement acceptor for Terms & Conditions #91

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

candemiralp
Copy link
Member

Summary

It has been observed that the module couldn't place any order if Terms & Conditions is enabled on the checkout as the required extension attributes were not passed to Magewire from the frontend. This PR implements the agreements acceptor as a part of extension attributes while placing order.

Tested scenarios

  • Placing order with card and Ideal payment methods while T&C is enabled/disabled.
  • Unit tests have been updated.

Fixes #70

Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@candemiralp candemiralp merged commit 5434da9 into develop Feb 19, 2025
5 of 7 checks passed
@candemiralp candemiralp deleted the ECP-9572 branch February 19, 2025 09:43
@candemiralp candemiralp mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ECP-9572] Agreements not accepted
3 participants