-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with adyen/module-payment 9.13.0 #93
Make compatible with adyen/module-payment 9.13.0 #93
Conversation
Hey @JustinElst, Thank you for the PR as contribution. It is much appreciated. Can you please also check the related unit test which makes the pipeline fail. After that I think we can merge the PR. |
It seems that your code-review environment is checking out the 'develop' branch and tests that. The develop branch will fail the tests because its not compatible with adyen/module-payment 9.13.0, hence this pull request 🎉 I created a pull request to possibly fix the checkout ref, check it out and re-run the tests for this pull-request: #95 |
There should go some thought into module upgrade path for this module, because 1.2.2 is not compatible with adyen/module-payment 9.13.0 but I'm thinking, should this pull-request mark a breaking change and a 1.3.0 or 2.0.0 release?
Or, will this be handled by just releasing this as 1.3.0?
|
Hey @JustinElst, Thank You for all the suggestions and the contributions. Yes, we are aware of this concern, and we truly appreciate you bringing it up. To ensure a smooth upgrade path, we are planning to address this by releasing a new version shortly. Here's the approach we're considering: Versioning for Compatibility:
Mitigating Risks:
Speedy Release:
Thanks again for highlighting this! Keep an eye out for the release updates. Regards! |
Description:
https://github.com/Adyen/adyen-magento2/pull/2819has made changes to the namespace of HeaderDataBuilder which is used in this module here
This PR implements the
HeaderDataBuilderInterface
to be compatible with 9.13.0 of Module PaymentFixes: