Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all services #608

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Update all services #608

merged 2 commits into from
Jan 31, 2024

Conversation

AdyenAutomationBot
Copy link
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Jan 16, 2024 •
edited
Loading

OpenAPI spec or templates produced changes on 30-01-2024 by commit.

@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner January 16, 2024 11:53
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 4 times, most recently from 6e36df2 to 8232f76 Compare January 22, 2024 08:36
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 3 times, most recently from 3353fb9 to eadb725 Compare January 26, 2024 15:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

81.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

wboereboom
wboereboom approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@wboereboom wboereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can safely ignore Sonar for now. It's triggering on generated code.
Sonar config should be updated to prevent this issue in the future.

@AlexandrosMor AlexandrosMor merged commit 5392fa9 into main Jan 31, 2024
3 of 4 checks passed
@AlexandrosMor AlexandrosMor deleted the sdk-automation/models branch January 31, 2024 08:01
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wboereboom wboereboom wboereboom approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdyenAutomationBot @wboereboom @AlexandrosMor