feat: add agoric-upgrade-18 (proposal 83) #211
Conversation
mujahidkay
force-pushed
the
mk/migrate-u18
branch
from
8cb322e to
8a4a980
Compare
There was a problem hiding this comment.
This meets the mechanical criteria of transferring the proposal and core-eval builds from agoric-sdk.
We could improve the code factoring but that's out of scope. This code won't be updated much at all so the duplication and possible confusion in naming isn't very consequential.
Heads up that this repo doesn't have autoquash so you'll have to do that locally before merging.
UPDATE: I took the liberty of doing that and force-pushing so you'd have a mergeable branch.
| ./verifyPushedPrice.js 'ATOM' 12.01 | ||
| ./verifyPushedPrice.js 'stATOM' 12.01 | ||
|
|
||
| ./openVault.js |
There was a problem hiding this comment.
in the future we might want some vstorage snapshot tests to document the new state the subsequent tests can depend on. Out of scope, just thinking out loud
| await registerOraclesForBrand(brand, oraclesByBrand); | ||
| console.log(`Registering Oracle for ${brand}`); | ||
|
|
||
| await verifyPushedPrice(price, brand, oraclesByBrand, ROUND_ID); |
There was a problem hiding this comment.
this function is poorly named because it's doing more than verifying: it's pushing prices. This script is also doing more: registering oracles.
I think it's okay to land but just wanted to point that out for your consideration.
turadg
force-pushed
the
mk/migrate-u18
branch
from
018f1fb to
3d89bce
Compare
Agoric/agoric-3-proposals#211 ## Description This PR updates a3p to use upgrade-18 image as well as remove u18 core proposals from upgrade.go. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations All testing as it updates the base image for a3p ### Upgrade Considerations Removes u18 core proposals from upgrade.go
Description
This PR adopts governance proposal 83 as per upgrade 18. Created via following instructions here.
Companion agoric-sdk PR
When a proposal passes on agoric-3 Mainnet, it should be included in the history that this synthetic image tracks.
fromTagusinglatest(such as a3p-integration) to use a fixed version (otherwise they will fail when this PR changes latest and they pick it up)use-${proposalName}(where proposalName is the part of the agoric-3-proposals proposal directory name after the colon, cf. a3p-integration/proposals)