-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump deps #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
execa was intentionally at 8.x across the board for #202; did something change? |
Maybe a newer version fixed it? I just tried a version bump and it passed CI. (Version bump prompted by an incompatibility with a3p-integration proposals that were using a 9.x) |
For future reference, execa v9.5.2 lib/utils/max-listeners.js and lib/terminate/cleanup.js do import |
Ugh? there is definitely a use.sh in upgrade-10. I actually don't see much having changed in there besides a refactor to synthetic-chain. |
There is. The reason it's not impacted is dependencies are independent per proposal and that one has an 8.x resolution for execa: https://github.com/Agoric/agoric-3-proposals/blob/main/proposals/34%3Aupgrade-10/package.json#L11-L14 |
That must be my mistake. GitHub CI logs for this PR appears to be using cached results for the relevant steps. |
incidental
@agoric/synthetic-chain library
Bump deps, mostly to update execa to latest to dedupe in consumers that are using new execa
This PR has the version bump so once this merges I'll
npm publish