Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump deps #214

Merged
merged 11 commits into from
Jan 17, 2025
Merged

bump deps #214

merged 11 commits into from
Jan 17, 2025

Conversation

turadg
Copy link
Member

@turadg turadg commented Jan 17, 2025

incidental

@agoric/synthetic-chain library

Bump deps, mostly to update execa to latest to dedupe in consumers that are using new execa

This PR has the version bump so once this merges I'll npm publish

@turadg turadg changed the title bump dumps bump deps Jan 17, 2025
Copy link

@iomekam iomekam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turadg turadg merged commit c613a31 into main Jan 17, 2025
2 checks passed
@turadg turadg deleted the ta/deps branch January 17, 2025 19:33
@gibson042
Copy link
Member

execa was intentionally at 8.x across the board for #202; did something change?

@turadg
Copy link
Member Author

turadg commented Jan 22, 2025

did something change?

Maybe a newer version fixed it? I just tried a version bump and it passed CI. (Version bump prompted by an incompatibility with a3p-integration proposals that were using a 9.x)

@gibson042
Copy link
Member

For future reference, execa v9.5.2 lib/utils/max-listeners.js and lib/terminate/cleanup.js do import addAbortListener, which did not exist before Node.js v18. But it looks like the steps of [34:upgrade-10] no longer include a use.sh, which is where the problem cropped up in #202. Hopefully we won't need to revisit this.

@mhofman
Copy link
Member

mhofman commented Jan 24, 2025

the steps of [34:upgrade-10] no longer include a use.sh

Ugh? there is definitely a use.sh in upgrade-10. I actually don't see much having changed in there besides a refactor to synthetic-chain.

@turadg
Copy link
Member Author

turadg commented Jan 24, 2025

there is definitely a use.sh in upgrade-10

There is. The reason it's not impacted is dependencies are independent per proposal and that one has an 8.x resolution for execa: https://github.com/Agoric/agoric-3-proposals/blob/main/proposals/34%3Aupgrade-10/package.json#L11-L14

@gibson042
Copy link
Member

That must be my mistake. GitHub CI logs for this PR appears to be using cached results for the relevant steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants