Adding video support for the API #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created an addon to the API to include video info (just what I need though -- feel free to add what you need to this!)
adding video functionality (in a very messy way, will update later -- just testing)
updating video stuffs
Cleaned up the description attribute since the alt text is now a thing in pexels api. Also added support for the avg_color attribute as well which was also in the search photos json but not in here.
Will add popular video and get video support later!
Trying to add video API support though frankly I'm not the best coder, but doing my best here.
…dule and class Actually fixing my dumb code this time.
This way we have 2 methods in case one works and the other doesn't. In this case I'm enforcing it to be all lowercase that way it remains consistent for the end user. But I think technically speaking, the alt text from Pexels is not necessarily in lower beforehand.
Closed
|
It is async and has video support: |
Thank you for your contribution @darkcurrent ! Great work. I'm not sure if this PR will ever get approved / merged. Creator hasn't been active on this project in years. But I appreciate the help at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't support popular videos yet or the "get video by id" function, but at least it's a start. I also didn't include the video preview JPGs either, but at least it would support videos.
I tried to make this PR as easy as possible for you to review but honestly I'm a junior coder at best so if you have any suggestions let me know and we can make it work better.