Always direct backup even when volume is in-use #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-mart
force-pushed
the
always-direct-backup
branch
from
e630ebc to
f42e353
Compare
c-mart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenStack Liberty, Cinder has supported non-disruptive volumes of in-use volumes. We don't need to take a separate snapshot, create a temporary volume from that snapshot, and back that up anymore. This change passes the
force=Trueflag when the volume is created, so that Cinder will always back up the volume even if it is in use.This will also make Ceph incremental backups work again (because subsequent backups will be backing up the same volume rather than different volumes).
(Note that right now this PR also contains these commits; will rebase against master before removing WIP in title.)