Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the build scripts for DISC and FA #18

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Optimize the build scripts for DISC and FA #18

merged 8 commits into from
Nov 7, 2024

Conversation

anw90
Copy link

@anw90 anw90 commented Oct 22, 2024 •
edited
Loading

  1. In setup.py, the two binary files that DISC depends on have been copied to ensure they can be found.
  2. Add the CUDA library path to LD_LIBRARY_PATH when building BladeDISC.

@anw90 anw90 changed the title Update DISC and FA bazel building scripts Optimize the build scripts for DISC and FA Oct 22, 2024
yitongh
yitongh reviewed Oct 23, 2024
View reviewed changes
bazel/flash_attn.BUILD Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@anw90 anw90 merged commit 3fda347 into acc Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yitongh yitongh yitongh approved these changes

@Yancey1989 Yancey1989 Awaiting requested review from Yancey1989

@Seventeen17 Seventeen17 Awaiting requested review from Seventeen17

@eedalong eedalong Awaiting requested review from eedalong

@lausannel lausannel Awaiting requested review from lausannel

@baoleai baoleai Awaiting requested review from baoleai

@hanwen-sun hanwen-sun Awaiting requested review from hanwen-sun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anw90 @yitongh