feat: add fail-safe when providing empty table type (#86)

Alkaar · Feb 14, 2023 · 6e693c9 · 6e693c9
1 parent a47c4f0
commit 6e693c9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/main/scala/com/resy/ResyClient.scala b/src/main/scala/com/resy/ResyClient.scala
@@ -187,8 +187,8 @@ class ResyClient(resyApi: ResyApi) extends Logging {
   ): Try[String] = {
     val results = reservationMap.get(resTimeTypes.head.reservationTime).flatMap { tableTypes =>
       resTimeTypes.head.tableType match {
-        case Some(tableType) => tableTypes.get(tableType.toLowerCase)
-        case None            => Some(tableTypes.head._2)
+        case Some(tableType) if tableType.nonEmpty => tableTypes.get(tableType.toLowerCase)
+        case _                                     => Some(tableTypes.head._2)
       }
     }
 

diff --git a/src/test/scala/com/resy/ResyClientSpec.scala b/src/test/scala/com/resy/ResyClientSpec.scala
@@ -83,6 +83,21 @@ class ResyClientSpec extends AnyFlatSpec with Matchers {
     ) shouldEqual Success("CONFIG_ID5")
   }
 
+  it should "find an available reservation with empty string as the table type" in new Fixture {
+    when(resyApi.getReservations(resDetails.date, resDetails.partySize, resDetails.venueId))
+      .thenReturn(Future(Source.fromResource("getReservations.json").mkString))
+
+    resyClient.findReservations(
+      date      = resDetails.date,
+      partySize = resDetails.partySize,
+      venueId   = resDetails.venueId,
+      resTimeTypes = Seq(
+        ReservationTimeType("18:00:00", "")
+      ),
+      millisToRetry = (.1 seconds).toMillis
+    ) shouldEqual Success("CONFIG_ID5")
+  }
+
   it should "find an available reservation with no table type preference" in new Fixture {
     when(resyApi.getReservations(resDetails.date, resDetails.partySize, resDetails.venueId))
       .thenReturn(Future(Source.fromResource("getReservations.json").mkString))