Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check unassociated DA/AD channels better #1982

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Check unassociated DA/AD channels better #1982

merged 4 commits into from
Jan 23, 2024

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Jan 17, 2024 •
edited
Loading

Close #1977

@t-b t-b self-assigned this Jan 17, 2024
@t-b t-b requested a review from timjarsky as a code owner January 17, 2024 21:45
@t-b t-b force-pushed the bugfix/1982-check-unassoc-channels-better branch from 5df6593 to 925c6fc Compare January 18, 2024 20:11
@t-b t-b force-pushed the bugfix/1982-check-unassoc-channels-better branch from 925c6fc to 394975c Compare January 19, 2024 22:29
@t-b t-b assigned MichaelHuth and unassigned t-b Jan 21, 2024
@MichaelHuth
Copy link
Collaborator

LGTM.

@MichaelHuth MichaelHuth assigned t-b and unassigned MichaelHuth Jan 22, 2024
@t-b t-b assigned timjarsky and unassigned t-b Jan 22, 2024
@t-b t-b merged commit 065b975 into main Jan 23, 2024
19 checks passed
@t-b t-b deleted the bugfix/1982-check-unassoc-channels-better branch January 23, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky timjarsky approved these changes

Assignees

@timjarsky timjarsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pre-Acquisition check that AD or DA gain is not zero for unassoc channels
3 participants
@t-b @MichaelHuth @timjarsky