Various minor changes from other PRs #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now we have only mentioned it in the release notes. Close #1995.
This fixes an issue where the SweepFormula help file (ihf) was not present on loading saved experiments which had a databrowser/sweepbrowser open. The reason was that we only loaded the ihf file on browser creation and that does not happen when loading an experiment. Now BSP_GetSFHELP loads the ihf file on-demand.
Bug introduced in fe7b00b (CI: Add ipt format to check formatting for PRs, 2024-03-28).
…ameters In 1abab43 (LBV_PopupExtGetLBKeys/LBV_PopupExtGetResultsKeys: Only list filled labnotebook entries, 2024-02-23) we added support for listing only filled labnotebook parameter names. Altough this works without issues filtering the lists takes quite some time. So we now cache them.
…ation and variable naming It is more intuitive to speak about the meaning of row and col contents.
Each test should create it if needed themselves and not rely on previous tests having created them.
… readable We have multiple layers in overrideResults since 299861a (PSX_FitEventDecay: Add an upper limit for the maximum tau, 2023-06-14). But as the test code already relies on tau being 1 we explicitly set it.
We don't use underscores in variable names.
t-b
force-pushed
the
feature/2091-various
branch
from
05439f5 to
89ab3ee
Compare
We are nearly always using the same branch names locally and remote so this should not change anything. But it does make the code clearer.
This allows to do git push origin feature/XXX-abcd when another branch is checked out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2061, #2023, #1894.
Will merge once CI passes.