tools: Don't include extras in the requirements.txt #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a CI issue where we could not regenerate the container image due to [1] 11 19.13 Collecting pydantic~=2.0 11 19.13 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: 11 19.13 pydantic~=2.0 from https://files.pythonhosted.org/packages/df/e4/ba44652d562cbf0bf320e0f3810206149c8a4e99cdbf66da82e97ab53a15/pydantic-2.9.2-py3-none-any.whl (from dandi==0.63.0->-r requirements.txt (line 364)) 11 ERROR: process "/bin/sh -c python -m venv --system-site-packages /home/ci/.venv && . /home/ci/.venv/bin/activate && pip3 install -r requirements.txt" did not complete successfully: exit code: 1 The exact source of the problem is unkonwn but regenerating tools/nwb-read-tests/requirements.txt on debian bookworm seems to fix the issue. As we also don't need the extras we can just not include them. [1]: https://github.com/AllenInstitute/MIES/actions/runs/11076005552/job/30822809003
t-b
force-pushed
the
bugfix/2270-requirements-no-extras
branch
from
dfd70f3 to
698f5fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a CI issue where we could not regenerate the container image due to 1
11 19.13 Collecting pydantic~=2.0
11 19.13 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
11 19.13 pydantic~=2.0 from https://files.pythonhosted.org/packages/df/e4/ba44652d562cbf0bf320e0f3810206149c8a4e99cdbf66da82e97ab53a15/pydantic-2.9.2-py3-none-any.whl (from dandi==0.63.0->-r requirements.txt (line 364))
11 ERROR: process "/bin/sh -c python -m venv --system-site-packages /home/ci/.venv && . /home/ci/.venv/bin/activate && pip3 install -r requirements.txt" did not complete successfully: exit code: 1
The problem is that pip from debian bookworm seems to be misparsing this entry.
As we also don't need the extras we can just not include them.