Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also look for git in PATH #2275

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Also look for git in PATH #2275

merged 2 commits into from
Oct 14, 2024

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Oct 14, 2024

Tested locally with commenting out the candidates trials.

Will merge once CI passes.

Close #2268

@t-b t-b self-assigned this Oct 14, 2024
@t-b t-b force-pushed the bugfix/2275-better-git-exec-finding branch from ec2d9a0 to 6175f77 Compare October 14, 2024 10:17
t-b added 2 commits October 14, 2024 12:20
In a future commit we want to adapt the way we set the gitPath variable.
Accompanying fix for 13e8467 (GetPossiblePathsToGit: Fix paths on
windows, 2024-09-27) as we now fallback to use git from PATH if none of
the candidate locations is usable.
@t-b t-b force-pushed the bugfix/2275-better-git-exec-finding branch from 6175f77 to 1af509c Compare October 14, 2024 10:22
@t-b t-b added the PR:NeedsBackport (Pull requests only) Mark it as requiring a backport to the latest release branch label Oct 14, 2024
@t-b t-b merged commit 453e7c8 into main Oct 14, 2024
20 checks passed
@t-b t-b deleted the bugfix/2275-better-git-exec-finding branch October 14, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:NeedsBackport (Pull requests only) Mark it as requiring a backport to the latest release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetPossiblePathsToGit() always fails
1 participant