Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining PAPlot tests #2277

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix remaining PAPlot tests #2277

merged 2 commits into from
Oct 14, 2024

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Oct 14, 2024

Will merge once CI passes.

t-b added 2 commits October 14, 2024 13:37
@t-b
PA_SpikePositionsForNonVC: Add missing /Q
2bc24da 
Otherwise FindPeak is too noisy.
@t-b
PAPlot tests: Update reference data for IP10
544c8ef 
There are minor changes in the subdigit area of the deconvoluted data.
Visual inspection revealed no relevant difference.

Let's adapt the reference data for IP10 to make the the tests pass.
@t-b t-b self-assigned this Oct 14, 2024
@t-b t-b merged commit 818d5fc into main Oct 14, 2024
18 checks passed
@t-b t-b deleted the bugfix/2277-make-tests-pass-with-ip10 branch October 14, 2024 17:17
@t-b t-b mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky is a code owner

@MichaelHuth MichaelHuth Awaiting requested review from MichaelHuth MichaelHuth is a code owner

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t-b