Fix SB_GetChannelInfo and prefer historic data tests #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By just skipping the input: path component for the files we make the function easier to use. And we also make it available for all.
In that way we have less large files in the repository. Back when we started to use Basic/input we did not ave historic data tests.
This was accidentally removed in 4574d76 (SweepBrowser: Prefer SB_GetSweepBrowserMapFromGraph, 2020-07-11). And as IP is very lenient in checking DFREFs, this was not caught by the compiler.
We want to only match the data files and not any backups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by PR while working on anaFuncParam.
Will merge once CI passes.