Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Remove colon from job name #2309

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Backport: Remove colon from job name #2309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dbc84b
.github/workflows/build-pr.yml: Remove colon from job names
t-b Dec 13, 2024
dc29f2d
.github/workflows/test-igor-rebase-exec-workflow.yml: Fix it for the …
t-b Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .github/workflows/build-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,7 @@ jobs:
run: tools/pre-commit/run.sh

CompilationTest:
name: |
👩🏾‍🔬 Compilation: ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
name: 👩🏾‍🔬 Compilation of ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
needs:
- BuildInstaller
strategy:
Expand All @@ -129,8 +128,7 @@ jobs:
hardware: false
uses: ./.github/workflows/test-igor-workflow.yml
with:
job_name: |
👩🏾‍🔬 Compilation: ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
job_name: 👩🏾‍🔬 Compilation of ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
overwrite_job_name: ${{ inputs.is_called_workflow || false }}
experiment: Packages/tests/Compilation/CompilationTester.pxp
installer_artifact_name: BuildInstaller-dev-assets
Expand All @@ -139,13 +137,11 @@ jobs:
timeout_minutes: 60

CompilationEachCommitTest:
name: |
👩🏾‍🔬 Compilation: Each commit
name: 👩🏾‍🔬 Compilation of each commit
if: ${{ !inputs.is_called_workflow }}
uses: ./.github/workflows/test-igor-rebase-exec-workflow.yml
with:
job_name: |
👩🏾‍🔬 Compilation: Each commit
job_name: 👩🏾‍🔬 Compilation of each commit
overwrite_job_name: ${{ inputs.is_called_workflow || false }}
experiment: Packages/tests/Compilation/CompilationTester.pxp
installer_flags: "-s git"
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/test-igor-rebase-exec-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,23 @@ jobs:
ref: ${{ github.sha }}
- name: Initial repo config
run: tools/initial-repo-config.sh
- name: Get latest release branch
run: |
CI_RELEASE_BRANCH=$(git branch --sort="version:refname" -rl "origin/release*" | tail -n1)
echo "CI_RELEASE_BRANCH=$CI_RELEASE_BRANCH" >> $GITHUB_ENV
- name: Gather base branch
run: |
CI_BASE_BRANCH=$((git merge-base --is-ancestor ${{ env.CI_RELEASE_BRANCH }} HEAD && echo "${{ env.CI_RELEASE_BRANCH }}") || echo "origin/main")
echo "CI_BASE_BRANCH=$CI_BASE_BRANCH" >> $GITHUB_ENV
- name: List of commits to operate on
run: git log --pretty=ref origin/main..
run: git log --pretty=ref ${{ env.CI_BASE_BRANCH }}..
- name: Cleanup earlier rebase invocations
run: git rebase --quit 2>/dev/null || true
- name: Compile check each commit with ${{ inputs.experiment }}
run: |
git rebase --exec "git log --pretty=ref -n1" \
--exec "tools/clean_mies_installation.sh ${{ inputs.installer_flags }}" \
--exec "tools/autorun-test.sh -p ${{ inputs.experiment }} -v IP_9_64" origin/main
--exec "tools/autorun-test.sh -p ${{ inputs.experiment }} -v IP_9_64" ${{ env.CI_BASE_BRANCH }}
- name: Gather log files and crash dumps
if: always()
run: tools/gather-logfiles-and-crashdumps.sh
Expand Down
Loading